Remove legacy correlate, dot, and multiply from backend #2183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderKalistratov
requested review from
antonwolfy,
npolina4,
vlad-perevezentsev and
vtavana
as code owners
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2183/index.html |
AlexanderKalistratov
force-pushed
the
correlate
branch
from
0d6a4e0 to
9083eeb
Compare
AlexanderKalistratov
force-pushed
the
remove_dot_and_multiply_from_backend
branch
from
c0f0457 to
46762fa
Compare
AlexanderKalistratov
force-pushed
the
correlate
branch
from
9083eeb to
8256472
Compare
AlexanderKalistratov
force-pushed
the
remove_dot_and_multiply_from_backend
branch
from
46762fa to
2f51c9e
Compare
AlexanderKalistratov
force-pushed
the
correlate
branch
from
8256472 to
5f793ab
Compare
AlexanderKalistratov
force-pushed
the
remove_dot_and_multiply_from_backend
branch
2 times, most recently
from
d64c029 to
fd2a20d
Compare
AlexanderKalistratov
changed the title
AlexanderKalistratov
force-pushed
the
correlate
branch
from
5f793ab to
2514037
Compare
AlexanderKalistratov
force-pushed
the
remove_dot_and_multiply_from_backend
branch
2 times, most recently
from
e3feeef to
ca1b3ef
Compare
vtavana
reviewed
Nov 20, 2024
AlexanderKalistratov
force-pushed
the
remove_dot_and_multiply_from_backend
branch
from
ca1b3ef to
7206e28
Compare
AlexanderKalistratov
force-pushed
the
correlate
branch
2 times, most recently
from
fbc94d0 to
fa3af10
Compare
6 tasks
antonwolfy
added a commit
that referenced
this pull request
Dec 4, 2024
Recent changes in DPC++ 2025.1 compiler broke DPNP compilation. It seems the legacy DPC++ compiler behavior was affected by introducing SYCL experimental extension for reduction properties. Since the compilation issue occurred for a backend function which will be removed once #2183 is merged, that PR proposes to temporary w/a the issue and to reuse the extension for reduction properties, which seems working.
github-actions bot
added a commit
that referenced
this pull request
Dec 4, 2024
Recent changes in DPC++ 2025.1 compiler broke DPNP compilation. It seems the legacy DPC++ compiler behavior was affected by introducing SYCL experimental extension for reduction properties. Since the compilation issue occurred for a backend function which will be removed once #2183 is merged, that PR proposes to temporary w/a the issue and to reuse the extension for reduction properties, which seems working. ed39ea7
antonwolfy
added a commit
that referenced
this pull request
Dec 5, 2024
Recent changes in DPC++ 2025.1 compiler broke DPNP compilation. It seems the legacy DPC++ compiler behavior was affected by introducing SYCL experimental extension for reduction properties. Since the compilation issue occurred for a backend function which will be removed once #2183 is merged, that PR proposes to temporary w/a the issue and to reuse the extension for reduction properties, which seems working.
AlexanderKalistratov
force-pushed
the
correlate
branch
from
fa3af10 to
70a7d8d
Compare
AlexanderKalistratov
force-pushed
the
correlate
branch
2 times, most recently
from
936870b to
be09e32
Compare
AlexanderKalistratov
force-pushed
the
correlate
branch
from
be09e32 to
91fd41f
Compare
AlexanderKalistratov
force-pushed
the
remove_dot_and_multiply_from_backend
branch
from
7206e28 to
6d17c49
Compare
vtavana
approved these changes
Dec 8, 2024
Contributor
vtavana
left a comment
vtavana
left a comment
There was a problem hiding this comment.
Thank you, @AlexanderKalistratov!
AlexanderKalistratov
force-pushed
the
correlate
branch
from
91fd41f to
943726f
Compare
antonwolfy
reviewed
Dec 11, 2024
Collaborator
Collaborator
Author
AlexanderKalistratov
left a comment
AlexanderKalistratov
left a comment
There was a problem hiding this comment.
@antonwolfy Please re-review
antonwolfy
reviewed
Jan 9, 2025
antonwolfy
approved these changes
Jan 13, 2025
Contributor
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @AlexanderKalistratov LGTM!
github-actions bot
added a commit
that referenced
this pull request
Jan 13, 2025
Removing `dot` and `multiply` legacy implementations and related legacy utilities from backend as no longer needed. 44bb068
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
dotandmultiplyimplementations from backend as no longer needed.Depends on PR #2183